View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000087 | Multi Theft Auto | Server | public | 2015-04-14 14:04 | 2024-10-08 12:03 |
Reporter | ixjf | Assigned To | ixjf | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | feedback | Resolution | open | ||
Product Version | 0.6 | ||||
Target Version | 0.6 | ||||
Summary | 0000087: Improve server bans code | ||||
Description | Currently, the ban system only does very basic IP strings comparison. If for example we passed the string "127.000.0.1" to Lua removeBan/BanManager::removeIP and the IP that was banned was "127.0.0.1", it wouldn't be unbanned. | ||||
Additional Information | BanManager::isBan still contains old code. | ||||
Tags | No tags attached. | ||||
|
Does this still affect 0.6 Nightly 2? |
|
If this hasn't been updated, it will definitely need to be, as IPv6 support has become a requirement. With the different types of IP formats now available, this will likely break the old code. |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-04-14 14:04 | ixjf | New Issue | |
2015-04-14 14:04 | ixjf | Status | new => assigned |
2015-04-14 14:04 | ixjf | Assigned To | => ixjf |
2015-07-04 03:12 | ixjf | Summary | Ban checks are simple string comparisons => Improve server bans code |
2015-07-04 03:12 | ixjf | Description Updated | |
2018-01-06 17:42 | SugarD-x | Note Added: 0000112 | |
2018-01-06 17:42 | SugarD-x | Status | assigned => feedback |
2024-10-08 12:03 | SugarD-x | Note Added: 0000213 |